Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(pie-tag): DSW-2550 pie tag icon only mode (v1) #2251

Closed
wants to merge 8 commits into from
Closed

feat(pie-tag): DSW-2550 pie tag icon only mode (v1) #2251

wants to merge 8 commits into from

Conversation

fernandofranca
Copy link
Contributor

Describe your changes (can list changeset entries if preferable)

@justeattakeaway/pie-tag

[Added] - supporting code for icon only mode
[Updated] - fixed padding in icon only mode

pie-storybook

[Added] - regular story for Tag icon only mode
[Added] - test stories for Tag icon only mode

pie-docs

[Added] - page for Tag icon only mode
[Updated] - content for Tag page regarding icon only mode

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code
  • I have added thorough tests where applicable (unit / component / visual)
  • I have reviewed the Docs site preview
  • If there are visual test updates, I have reviewed them properly before approving

Reviewer checklists (complete before approving)

Reviewer 1

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

Reviewer 2

  • I have reviewed the Docs site preview
  • If new links have been added, I have tested them in the preview
  • If there are visual test updates, I have reviewed them

@fernandofranca fernandofranca requested review from a team as code owners February 28, 2025 13:11
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 28, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 51de2f1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 9 packages
Name Type
@justeattakeaway/pie-tag Minor
pie-storybook Minor
pie-docs Minor
@justeattakeaway/pie-webc Patch
wc-angular12 Patch
wc-nuxt2 Patch
wc-react17 Patch
wc-react18 Patch
wc-vue3 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pie-design-system-bot
Copy link
Contributor

pie-design-system-bot commented Feb 28, 2025 •
edited
Loading




Fails
🚫 You have unchecked checklist items outside the "Not-applicable Checklist items" section.

Please ensure all unchecked checkboxes are moved to the appropriate section.
🚫 You have unchecked checklist items in Reviewer 1's section.

Please ensure all items are addressed before approval.
🚫 You have unchecked checklist items in Reviewer 2's section.

Please ensure all items are addressed before approval.

Generated by 🚫 dangerJS against 51de2f1

@fernandofranca fernandofranca changed the title Dsw 2550 pie tag icon only feat(pie-tag):DSW-2550 pie tag icon only Feb 28, 2025
@fernandofranca fernandofranca changed the title feat(pie-tag):DSW-2550 pie tag icon only feat(pie-tag): DSW-2550 pie tag icon only Feb 28, 2025
@fernandofranca fernandofranca changed the title feat(pie-tag): DSW-2550 pie tag icon only feat(pie-tag): DSW-2550 pie tag icon only mode Feb 28, 2025
@fernandofranca fernandofranca force-pushed the DSW-2550-pie-tag-icon-only branch from 592085f to d574459 Compare February 28, 2025 13:17
@fernandofranca fernandofranca force-pushed the DSW-2550-pie-tag-icon-only branch from aac8792 to 91d9304 Compare February 28, 2025 14:38
@fernandofranca fernandofranca force-pushed the DSW-2550-pie-tag-icon-only branch from 91d9304 to 51de2f1 Compare February 28, 2025 15:03
@fernandofranca fernandofranca changed the title feat(pie-tag): DSW-2550 pie tag icon only mode feat(pie-tag): DSW-2550 pie tag icon only mode (v1) Mar 3, 2025
@fernandofranca
Copy link
Contributor Author

Closing the PR per deployment and test issues. Opened a new one here: #2253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raoufswe raoufswe raoufswe left review comments

@dandel10n dandel10n dandel10n approved these changes

Assignees
No one assigned
Labels
apps components pie-docs pie-storybook pie-tag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fernandofranca @pie-design-system-bot @dandel10n @raoufswe